Add support for NonNull function attribute #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuillaumeGomez
force-pushed
the
non-null
branch
from
8db7f6f
to
87706ed
Compare
GuillaumeGomez
force-pushed
the
non-null
branch
from
87706ed
to
1783a47
Compare
GuillaumeGomez
force-pushed
the
non-null
branch
from
1783a47
to
096f14d
Compare
antoyo
reviewed
Oct 17, 2023
src/abi.rs
Outdated
| } | ||
|
|
||
| fn ptr_to_gcc_type(&self, cx: &CodegenCx<'gcc, 'tcx>) -> Type<'gcc> { | ||
| let (return_type, params, variadic, on_stack_param_indices) = self.gcc_type(cx); | ||
| // FIXME: Should we do something with `fn_attrs`? |
There was a problem hiding this comment.
I have the feeling that we should, since I handled the on stack parameters below.
But I'm not sure how to double-check this.
antoyo
reviewed
Oct 17, 2023
GuillaumeGomez
force-pushed
the
non-null
branch
from
4bffad5
to
0c4fe2f
Compare
antoyo
reviewed
Oct 17, 2023
GuillaumeGomez
force-pushed
the
non-null
branch
from
0c4fe2f
to
0348a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on rust-lang/gcc#28 and on rust-lang/gccjit.rs#23.